----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54521/#review158559 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Dec. 8, 2016, 6:02 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54521/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 6:02 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > When master starts with implicit roles, if there is no framework > running under "*" role, it is not included anymore in the response > of `getRoles` API. > > > Diffs > ----- > > src/master/http.cpp d410c2f725206a9879a3026adff305c7aed2e98f > src/tests/role_tests.cpp 7e486d86fbc03aea1462d99fd59fce07b2ad30d7 > > Diff: https://reviews.apache.org/r/54521/diff/ > > > Testing > ------- > > make > ./bin/mesos-tests.sh --gtest_filter="RoleTest.*" > make check > > Also start a master with implicit roles and query /roles endpoint to see > there's not "*" role in response anymore. > > > Thanks, > > Jay Guo > >
