----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54515/#review158591 -----------------------------------------------------------
Patch looks great! Reviews applied: [54335, 54514, 54515] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Dec. 8, 2016, 8:22 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54515/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 8:22 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6722 > https://issues.apache.org/jira/browse/MESOS-6722 > > > Repository: mesos > > > Description > ------- > > Instead of the absolute path `/var/run/mesos`, `os::runtime_dir()` returns a > platform-specific and permissions checked path for runtime data. > > This updates the `Flags::runtime_dir` to simply default to `os::runtime_dir()` > instead of having platform-specific code in the CLI, thus fully resolving > MESOS-6722. The POSIX implementation of `os::runtime_dir()` also resolves the > comparison of `user == "root"` as a permission check by correctly checking the > permissions using `os::access`. > > This updates the `Flags::docker_volume_checkpoint_dir` to use > `path::join(os::var(), ...)` instead of a hardcoded `/var/run/mesos` path. > > > Diffs > ----- > > src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3 > > Diff: https://reviews.apache.org/r/54515/diff/ > > > Testing > ------- > > make && make check on Linux: no failures. > msbuild and attach to a master on Windows: no failures. > > Checked that running agent as non-root on Linux *without* read/write > permissions to `/var/run` > correctly fell back to `/tmp/mesos/runtime`. > > Checked that running as `root` on Linux and `Administrator` on Windows > chose the correct default `runtime_dir` paths. > > > Thanks, > > Andrew Schwartzmeyer > >
