----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54178/#review158600 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Nov. 30, 2016, 9:03 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54178/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 9:03 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6619 > https://issues.apache.org/jira/browse/MESOS-6619 > > > Repository: mesos > > > Description > ------- > > This is similar to the LinkedHashMap and Cache constructs. > > Unlike LinkedHashMap, a BoundedHashMap has a fixed maximum capacity: > when the BoundedHashMap is at capacity, inserting another element > results in removing the oldest element still in the map (i.e., FIFO > order is used for eviction). > > Unlike Cache, reading an element from a BoundedHashMap does not change > which entry is evicted next. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4e10ae25a6c8a2d01d7b98b04ccf06a216611938 > 3rdparty/stout/include/Makefile.am d5bc728ce378586e84173b98499b0d52047a83e1 > 3rdparty/stout/include/stout/boundedhashmap.hpp PRE-CREATION > 3rdparty/stout/tests/boundedhashmap_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54178/diff/ > > > Testing > ------- > > `make check` > > Note that this is based on the revised design of LinkedHashMap, which in a > concurrent RR has been modified to support `foreachpair` and friends. See > https://reviews.apache.org/r/54018/ > > > Thanks, > > Neil Conway > >