----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54560/#review158616 -----------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.hpp (line 237) <https://reviews.apache.org/r/54560/#comment229404> s/as type `Duration()`/e.g., '5s', '10mins')/ src/slave/containerizer/mesos/io/switchboard.cpp (line 1169) <https://reviews.apache.org/r/54560/#comment229405> s/Send/send/ src/slave/containerizer/mesos/io/switchboard.cpp (line 1518) <https://reviews.apache.org/r/54560/#comment229406> hmm. instead of `UNREACHABLE` this should return `BadRequest` or `Unimplemented`. this will handle the case when a client sends a new type of control message that the SB doesn't understand yet (old version) src/slave/containerizer/mesos/io/switchboard.cpp (line 1558) <https://reviews.apache.org/r/54560/#comment229407> ditto. see above. src/slave/flags.cpp (line 267) <https://reviews.apache.org/r/54560/#comment229403> see below: should we name it in a generic way? e.g., "--enable_debugging" src/slave/flags.cpp (line 278) <https://reviews.apache.org/r/54560/#comment229401> i think most users don't understand what an "io switchboard" is. wondering if we should name the flag something more generic like "http_heartbeat_interval" and in the help say it is currently used for ATTACH_ and LAUNCH_ http calls. src/slave/flags.cpp (line 281) <https://reviews.apache.org/r/54560/#comment229400> s/as type `Duration()`/e.g., '5s', '10mins')/ that way users don't have to understand what `Duration` means typically. src/slave/flags.cpp (lines 285 - 286) <https://reviews.apache.org/r/54560/#comment229399> The default gets printed out in help. So no need for "The default is 30 seconds". - Vinod Kone On Dec. 9, 2016, 1:18 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54560/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 1:18 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-6763 > https://issues.apache.org/jira/browse/MESOS-6763 > > > Repository: mesos > > > Description > ------- > > Added a heartbeat for both input/output connections on an IOSwitchboard. > > > Diffs > ----- > > include/mesos/agent/agent.proto 9d5c3e786cbb89416bb9a423569602b8b2549752 > include/mesos/v1/agent/agent.proto d0fdf293c40d8c797711077e40c483c6a059004a > src/slave/containerizer/mesos/io/switchboard.hpp > ae4c48d3ce0252189bc1a098c26f25ba30c870c9 > src/slave/containerizer/mesos/io/switchboard.cpp > 93a6b274f7ecb8e2fcd4bb74b266d999e89e2b02 > src/slave/containerizer/mesos/io/switchboard_main.cpp > 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd > src/slave/flags.hpp 02af2845e8c2baf03c83c7eab897725f6e2e9752 > src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3 > > Diff: https://reviews.apache.org/r/54560/diff/ > > > Testing > ------- > > Tests in subsequent patch. Because of a pending unix domain socket reconnect > bug, committing the tests and running them in the standard way would break > the build currently. > > > Thanks, > > Kevin Klues > >
