----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54597/#review158699 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/pipe.hpp (line 27) <https://reviews.apache.org/r/54597/#comment229489> Just use a UUID. 3rdparty/stout/include/stout/os/windows/pipe.hpp (lines 66 - 68) <https://reviews.apache.org/r/54597/#comment229490> Close the read end on the way out. - Michael Park On Dec. 9, 2016, 10:18 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54597/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 10:18 a.m.) > > > Review request for mesos and Daniel Pravat. > > > Repository: mesos > > > Description > ------- > > Introduced an `os::pipe` abstraction in stout. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION > 3rdparty/stout/include/stout/posix/os.hpp > 8443aa0cf0a8d8d52e36282611c2ab15ca4dd354 > 3rdparty/stout/include/stout/windows/os.hpp > 2f20ccc64e255a60a1b7f33d684969942f12e45f > > Diff: https://reviews.apache.org/r/54597/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
