----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54519/#review158614 -----------------------------------------------------------
Ship it! LGTM. I'm going to reword a bit of the description though :) - Joseph Wu On Dec. 7, 2016, 6:22 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54519/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 6:22 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-6717 > https://issues.apache.org/jira/browse/MESOS-6717 > > > Repository: mesos > > > Description > ------- > > This commit will partially address MESOS-6717, specifically moving > `os::getenv` to its own file in preparation for review #54489,in which > will transition `os::temp` to look for the environment variable `TMPDIR` > before falling back to `/tmp` on POSIX environments. > > In other words, `temp.hpp` needs to call `os::getenv`, but it is highly > undesirable to have `temp.hpp` take a dependency on `os.hpp` (where it > currently resides), since `os.hpp` is supposed to aggregate all .hpp > files in `stout/os/`, and therefore, no files in `stout/os/` should be > taking a dependency on it. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/posix/os.hpp > 8443aa0cf0a8d8d52e36282611c2ab15ca4dd354 > 3rdparty/stout/include/stout/windows/os.hpp > 2f20ccc64e255a60a1b7f33d684969942f12e45f > > Diff: https://reviews.apache.org/r/54519/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
