----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54490/#review158480 -----------------------------------------------------------
Ship it! LGTM. - Joseph Wu On Dec. 7, 2016, 11:06 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54490/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 11:06 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and > Joseph Wu. > > > Bugs: MESOS-6717 > https://issues.apache.org/jira/browse/MESOS-6717 > > > Repository: mesos > > > Description > ------- > > This commit will partially address MESOS-6717, and will continue the > effort started in review #54489 to remove POSIX-specific temporary > directory selection logic out of the Agent test harness, and into > Stout's `os::temp`. For a more detailed justification, see this review. > > > Diffs > ----- > > src/tests/environment.cpp ba75043a2a3813c70ed99aecfd979ba305d7a383 > > Diff: https://reviews.apache.org/r/54490/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
