----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review158737 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Nov. 23, 2016, 10:34 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50857/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 10:34 a.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > This patch modifies the test SchedulerTest.Teardown to > be parametrized by both ContentType and SSL configuration, > and renames it to SchedulerSSLTest.RunTaskAndTeardown. > This allows the test to verify the scheduler's behavior with > SSL both enabled and disabled. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp c031823843a8ae5ecbccf60b9edf83ec1afcc5e6 > > Diff: https://reviews.apache.org/r/50857/diff/ > > > Testing > ------- > > All testing was done on CentOS 7: > > `make check` ran and all tests passed. > > `3rdparty/libprocess/libprocess-tests --gtest_repeat=-1 > --gtest_break_on_failure` ran for several hundred repetitions with no > failures. > > `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest*" > --gtest_repeat=-1 --gtest_break_on_failure` ran for about 1,000 repetitions > without failing. > > `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.SocketEOF/*" > --gtest_repeat=-1 --gtest_break_on_failure` ran for about 4,000 repetitions > without failing. > > `3rdparty/libprocess/libprocess-tests --gtest_filter="*HTTPTest.Endpoints/*" > --gtest_repeat=-1 --gtest_break_on_failure` ran for about 10,000 repetitions > without failing. > > `bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure` ran for > several hundred repetitions with no failures. > > `bin/mesos-tests.sh --gtest_filter="*SchedulerSSLTest*" --gtest_repeat=-1 > --gtest_break_on_failure` ran for about 2,000 repetitions without failing. > > > Thanks, > > Greg Mann > >
