----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review158750 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 408) <https://reviews.apache.org/r/54449/#comment229552> Not that we are on the subject of readability, mind explaning these zeros? ``` if (::quotactl(QCMD(Q_XGETQSTATV, 0), // `type` is ignored for Q_XGETQSTATV. ``` This would help people like me in understanding how it works. :) src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 410) <https://reviews.apache.org/r/54449/#comment229551> 0, // The `id` argument is ignored for `Q_XGETQSTATV`. - Jiang Yan Xu On Dec. 9, 2016, 5:14 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54449/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 5:14 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-6732 > https://issues.apache.org/jira/browse/MESOS-6732 > > > Repository: mesos > > > Description > ------- > > The XFS disk isolator checks that the filesystem is XFS, but doesn't > check whether project quotas are actually enabled. This means that > an invalid configuration will start but will always fail when tasks > are launched. > > Add a check to test whether project quotas are enabled on the work > directory and fail hard if they are not. > > > Diffs > ----- > > configure.ac 7a18c89854c1f42bec09f067579b72114fb8ec1d > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > 7602fe3b6ab069db643397418732e773d0417f8a > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > b9d8e7dc999ba3064bee7105eff0f9553d825df8 > > Diff: https://reviews.apache.org/r/54449/diff/ > > > Testing > ------- > > Make check on Fedora 25. Manual test on F25 with mesos-execute. > > > Thanks, > > James Peach > >
