----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54544/#review158766 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp (line 3977) <https://reviews.apache.org/r/54544/#comment229571> s/if the client connection breaks/upon a client disconnection src/tests/api_tests.cpp (line 4047) <https://reviews.apache.org/r/54544/#comment229568> Comma after Ideally src/tests/api_tests.cpp (lines 4047 - 4049) <https://reviews.apache.org/r/54544/#comment229569> Can you file an issue for this so that it's tracked? src/tests/api_tests.cpp (line 4080) <https://reviews.apache.org/r/54544/#comment229570> AWAIT_READY(connection.disconnect()); Would be useful for debugging later. If this future itself fails for some reason, the next line won't future would never be ready. - Anand Mazumdar On Dec. 8, 2016, 9:53 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54544/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 9:53 p.m.) > > > Review request for mesos, Anand Mazumdar and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Tests that when a client is disconnected the container is destroyed. > > > Diffs > ----- > > src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 > > Diff: https://reviews.apache.org/r/54544/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
