> On Nov. 30, 2016, 3:18 p.m., Neil Conway wrote: > > src/master/master.hpp, line 2589 > > <https://reviews.apache.org/r/54179/diff/1/?file=1572516#file1572516line2589> > > > > On reflection, this does change behavior slightly: previously, > > `completedTasks` could contain multiple completed tasks with the same task > > ID (this is not illegal because frameworks are allowed to reuse task IDs > > after the task has reached a terminal state). Using a `BoundedHashMap` > > means we'll store at most a single completed task with a given ID. Do we > > want to preserve the previous behavior?
This has been reverted. See also MESOS-6779. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54179/#review157412 ----------------------------------------------------------- On Dec. 12, 2016, 7:03 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54179/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 7:03 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6619 > https://issues.apache.org/jira/browse/MESOS-6619 > > > Repository: mesos > > > Description > ------- > > This replaces a few instances where boost::circular_buffer was > previously used. > > > Diffs > ----- > > src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac > src/master/master.hpp c304e69af0b7a720ea8277088cabc0675eec8b57 > src/master/master.cpp 8c1c7f94102a2f40fbdffaa36f2d1c15e78a906d > > Diff: https://reviews.apache.org/r/54179/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
