----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54681/#review158934 -----------------------------------------------------------
Ship it! I'm fine with shipping this as is. It might be nice to print all missing flags at once though so that you don't have to run it mutliple times to catch all of the missing flags. I think it's fine for now though. - Kevin Klues On Dec. 13, 2016, 12:11 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54681/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 12:11 a.m.) > > > Review request for mesos, Benjamin Bannier and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Although these flags are now optional, we actually require them to be > set when executing the mesos-io-switchbaord binary. We add a check to > make sure they are set properly. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.hpp > fb720f063396790a336170dcb4b103c844c8d2dc > src/slave/containerizer/mesos/io/switchboard.cpp > 210556f6ea60364a6332a07f294331b4d3457ff0 > src/slave/containerizer/mesos/io/switchboard_main.cpp > 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd > > Diff: https://reviews.apache.org/r/54681/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
