----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54685/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, John Kordich, and Joseph Wu. Repository: mesos Description ------- Commit f61f321b calls a macro, `INSTANTIATE_TEST_CASE_P`, with some arguments `#ifdef`'d. This breaks MSVC 1900 build; the specification does not require the text a macro expands to be processed, which means that the un-processed `#ifdef` ends up in the expansion of `INSTANTIATE_TEST_CASE_P`, which causes a build-time error. This commit will resolve this problem by moving the `#ifdef` to surround the invocation of `INSTANTIATE_TEST_CASE_P` instead of being around the arguments to the macro. Diffs ----- 3rdparty/libprocess/src/tests/http_tests.cpp 822cdb3931d3e30713aa78995427f364e41bfb30 Diff: https://reviews.apache.org/r/54685/diff/ Testing ------- Thanks, Alex Clemmer
