----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review158963 -----------------------------------------------------------
include/mesos/mesos.proto (line 1106) <https://reviews.apache.org/r/54693/#comment229853> ``` // Blkio statistics. ``` include/mesos/mesos.proto (line 2225) <https://reviews.apache.org/r/54693/#comment229855> We need add a comment that when `device` is emtpy, it represent `All`. include/mesos/mesos.proto (lines 2228 - 2229) <https://reviews.apache.org/r/54693/#comment229856> I am not sure in which case we need the non-recursive one. If we don't have user cases which need this, maybe we could remove it? src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp (lines 52 - 55) <https://reviews.apache.org/r/54693/#comment229857> Let's only add defintions for proto in this file. - haosdent huang On Dec. 13, 2016, 5:12 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54693/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 5:12 a.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, haosdent huang, Jie > Yu, Kunal Thakar, and Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Add ProtoBuf schema for Blkio cgroups per the kernel Blkio controller doc. > > > Diffs > ----- > > include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/54693/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
