----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54661/#review158973 -----------------------------------------------------------
Looks like we don't ever return Forbidden in this new code path.. src/slave/http.cpp (line 766) <https://reviews.apache.org/r/54661/#comment229870> Is the plan to move everything over to the ObjectApprover API? I notice that the v0 /flags endpoint just calls `slave->authorizer.get()->authorized(authRequest)` Should we update it too? src/slave/http.cpp (line 775) <https://reviews.apache.org/r/54661/#comment229872> Don't you need to check `approver->approved()` before you return OK or Forbidden? - Adam B On Dec. 12, 2016, 6:35 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54661/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 6:35 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Adds the stub which allows for restriction of users when attempting > to access the `GET_FLAGS` API v1 call. > > > Diffs > ----- > > src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b > > Diff: https://reviews.apache.org/r/54661/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
