----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158976 -----------------------------------------------------------
Looks good, but I'm tired. I'll merge all these in tomorrow. src/slave/http.cpp (line 1869) <https://reviews.apache.org/r/54538/#comment229880> Each parameter on a separate line, please src/slave/http.cpp (line 1929) <https://reviews.apache.org/r/54538/#comment229884> Already called `info` a few lines above. Can you reuse that? - Adam B On Dec. 12, 2016, 2:46 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54538/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 2:46 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Enables fine grained authorization for the v1 API call `GET_CONTAINERS`. > > > Diffs > ----- > > src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b > src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a > > Diff: https://reviews.apache.org/r/54538/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
