----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54333/#review159349 -----------------------------------------------------------
src/master/http.cpp (line 996) <https://reviews.apache.org/r/54333/#comment230312> Had the `Content-Type` been `application/x-www-form-urlencoded` or other form related content type, it would have made sense to have the "form body" suffix. How about: ``` Missing 'slaveId' query parameter in the request body ``` Ditto for all the other occurences. In hindsight, it won't have been a bad idea to pass them in the URL itself initially. The opinion though on it are pretty divided when using `POST`. :-) - Anand Mazumdar On Dec. 3, 2016, 2:14 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54333/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 2:14 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > I've been told that since we're looking at the request __body__ > for the parameters as opposed to the URL, we should report that there > is an error in the "form body" as opposed to a "query parameter". > > > Diffs > ----- > > src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f > > Diff: https://reviews.apache.org/r/54333/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
