----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54631/#review159387 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/os/write.hpp (lines 86 - 87) <https://reviews.apache.org/r/54631/#comment230374> This copy-pasted comment is not needed. - Joseph Wu On Dec. 10, 2016, 2:51 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54631/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2016, 2:51 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-6706 > https://issues.apache.org/jira/browse/MESOS-6706 > > > Repository: mesos > > > Description > ------- > > This commit will partially address MESOS-6706, specifically a bug > causing calls to `os::write` to fail on Windows for all tests in > `files_tests.cpp`. > > On Windows, calling `os::write` with a `char *` literal (e.g., > `os::write("your_file", ...)` will erroneously dispatch to the overload > of `os::write(HANDLE)` instead of `os::write(const string&)`, because > `HANDLE` is a typedef'd `void *`. > > In this commit, we simply add an overload for `char *`, which resolves > the ambiguity and causes most tests in `files_tests.cpp` to pass. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > 24a69d8f60efd3c2888d464d75164c758b3701a2 > > Diff: https://reviews.apache.org/r/54631/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
