> On Dec. 16, 2016, 4:27 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [54803, 54677, 54618, 54611, 53706, 52624, 52625, 52972, > > 52544, 52364] > > > > Failed command: ./support/apply-review.sh -n -r 52544 > > > > Error: > > 2016-12-16 04:26:46 URL:https://reviews.apache.org/r/52544/diff/raw/ > > [15399/15399] -> "52544.patch" [1] > > error: patch failed: 3rdparty/stout/include/stout/os.hpp:47 > > error: 3rdparty/stout/include/stout/os.hpp: patch does not apply > > > > Full log: https://builds.apache.org/job/mesos-reviewbot/16468/console
This patch is bad because of dpravat's stale `os::user` review. Let's remove the dependency. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159409 ----------------------------------------------------------- On Dec. 16, 2016, 2:47 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54803/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2016, 2:47 a.m.) > > > Review request for mesos, Adam B, Andrew Schwartzmeyer, Daniel Pravat, Greg > Mann, John Kordich, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-6803 > https://issues.apache.org/jira/browse/MESOS-6803 > > > Repository: mesos > > > Description > ------- > > Currently, when `HAS_AUTHENTICATION` is undefined, the Agent will > use `delay` to schedule a random time in the future to register with the > Master, to avoid the thundering herd problem after a Master failover. > The authentication codepath, in contrast, schedules the registration > immediately. > > In tests where we have `Clock::pause`'d when we are supposed to be > registering the slave, the authention codepath will succeeed, while > no-authentication codepath will hang forever. > > A much more detailed analysis of this situation exists in MESOS-6803. > > This commit will resolve this issue for `slave_tests.cpp` by changing > the tests to not use `Clock::pause` when we are waiting for Agent > registration. > > > Diffs > ----- > > src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3 > > Diff: https://reviews.apache.org/r/54803/diff/ > > > Testing > ------- > > Added `delay` to the call to `authenticate` in `Slave::detected`, ran tests > to find failing tests in `SlaveTest.*`, then fixed, then ran again. > > > Thanks, > > Alex Clemmer > >
