> On 十二月 17, 2016, 10:19 a.m., Jay Guo wrote: > > src/common/resources.cpp, lines 1082-1083 > > <https://reviews.apache.org/r/54830/diff/2/?file=1588444#file1588444line1082> > > > > Maybe "We do not expect allocated and unallocated resource objects > > being stored within the same `Resources` object."?
I updated this to "We do not expect unallocated resource objects being stored within the this `Resources` object." - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54830/#review159546 ----------------------------------------------------------- On 十二月 17, 2016, 4:28 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54830/ > ----------------------------------------------------------- > > (Updated 十二月 17, 2016, 4:28 a.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Repository: mesos > > > Description > ------- > > Added helper function to get per-role resource allocations. > > > Diffs > ----- > > include/mesos/resources.hpp f569c931ff7db8d51dfd7c96f4f2addab05df85d > include/mesos/v1/resources.hpp f60ab794a0c7c24885c49cc47b798c363e3279e7 > src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f > src/tests/resources_tests.cpp d6eb7787bac58c1133a4bab0fc17df49117fed87 > src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 > > Diff: https://reviews.apache.org/r/54830/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --gtest_filter="AllocatedResourcesTest.Allocations" > --verbose > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from AllocatedResourcesTest > [ RUN ] AllocatedResourcesTest.Allocations > [ OK ] AllocatedResourcesTest.Allocations (0 ms) > [----------] 1 test from AllocatedResourcesTest (0 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (17 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
