----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54716/#review159552 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 177) <https://reviews.apache.org/r/54716/#comment230585> I think this comment needs to be updated since you have changed the value of this hashmap from network configuration info to the path of network configuration file. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 269) <https://reviews.apache.org/r/54716/#comment230581> s/errors/error/ src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 303) <https://reviews.apache.org/r/54716/#comment230583> Do we need to mention the same network name twice in this message? I think for the later one we can just mention it as "it", like: ``` Skipping network xxx from configuration file '/xxx', since we failed to find CNI plugin 'yyy' used by it. ``` src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 319) <https://reviews.apache.org/r/54716/#comment230584> Ditto. - Qian Zhang On Dec. 17, 2016, 4:16 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54716/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2016, 4:16 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6567 > https://issues.apache.org/jira/browse/MESOS-6567 > > > Repository: mesos > > > Description > ------- > > Since the `network/cni` isolator will soon be able to > add/modify/delete CNI configuration files without the need for agent > restart, we are changing the initialization logic to not bail out if > we see errors while reading a CNI configuration file or don't find a > CNI plugin for a given CNI configuration. If either of these errors > occur the `network/cni` isolator would simply skip the specific CNI > network and complete the initialization. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > b8fc755a8dd4757d904f7e97a71d3cf7f29d2033 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049 > > Diff: https://reviews.apache.org/r/54716/diff/ > > > Testing > ------- > > sudo make check --gtest_filter=*CNI* > > > Thanks, > > Avinash sridharan > >
