-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54873/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-4853 and MESOS-6129
https://issues.apache.org/jira/browse/MESOS-4853
https://issues.apache.org/jira/browse/MESOS-6129
Repository: mesos
Description
-------
This patch integrates libcurl with Mesos's event runtime. It uses the
multi interface (https://curl.haxx.se/libcurl/c/libcurl-multi.html).
A few TODO items:
1) Consider introducing a connection 'Pool' concept (i.e., using one
multi handle and multiple easy handles).
2) Revise the discard semantics.
3) Introduce a return type from libcurl where you can get information
about the execution.
4) More verbose logging for debugging.
Diffs
-----
src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b
src/curl/common.hpp PRE-CREATION
src/curl/common.cpp PRE-CREATION
src/tests/curl_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54873/diff/
Testing
-------
```
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CurlTest
[ RUN ] CurlTest.SimpleUrl
* About to connect() to registry-1.docker.io port 443 (#0)
* Trying 52.45.221.131...
* Connected to registry-1.docker.io (52.45.221.131) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
* CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
* SSL connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate:
* subject: CN=*.docker.io,OU=Domain Control Validated -
RapidSSL(R),OU=See www.rapidssl.com/resources/cps (c)15,OU=GT98568428
* start date: Mar 19 17:34:32 2015 GMT
* expire date: Apr 21 01:51:52 2018 GMT
* common name: *.docker.io
* issuer: CN=RapidSSL SHA256 CA - G3,O=GeoTrust Inc.,C=US
> GET /v2/ HTTP/1.1
Host: registry-1.docker.io
Accept: */*
< HTTP/1.1 401 Unauthorized
< Content-Type: application/json; charset=utf-8
< Docker-Distribution-Api-Version: registry/2.0
< Www-Authenticate: Bearer
realm="https://auth.docker.io/token",service="registry.docker.io";
< Date: Mon, 19 Dec 2016 20:22:27 GMT
< Content-Length: 87
< Strict-Transport-Security: max-age=31536000
<
{"errors":[{"code":"UNAUTHORIZED","message":"authentication
required","detail":null}]}
* Connection #0 to host registry-1.docker.io left intact
[ OK ] CurlTest.SimpleUrl (451 ms)
[----------] 1 test from CurlTest (451 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (520 ms total)
[ PASSED ] 1 test.
```
Thanks,
Jie Yu
