----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53717/#review159673 -----------------------------------------------------------
Ship it! I can tweak these before committing. src/docker/executor.cpp (lines 56 - 59) <https://reviews.apache.org/r/53717/#comment230692> This should be grouped with the other libprocess headers above. src/docker/executor.cpp (line 689) <https://reviews.apache.org/r/53717/#comment230693> Missing a `// __WINDOWS__`. - Joseph Wu On Nov. 13, 2016, 9:43 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53717/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 9:43 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added `Winsock` initialization in `docker-mesos-executor`. > > > Diffs > ----- > > src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 > > Diff: https://reviews.apache.org/r/53717/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
