----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54875/#review159699 -----------------------------------------------------------
Patch looks great! Reviews applied: [54875] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Dec. 19, 2016, 10:12 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54875/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 10:12 p.m.) > > > Review request for mesos and Alex Clemmer. > > > Repository: mesos > > > Description > ------- > > Windows builds without this flag instruct you to add it, > but the instructions were missing the prefix `D` for define, > and so as-is resulted in an error message. > This could be a source of frustration for those who > do not know CMake. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake d8575873eb315f812ba281564c42d848915349de > > Diff: https://reviews.apache.org/r/54875/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
