> On Dec. 21, 2016, 4:57 p.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, line 800 > > <https://reviews.apache.org/r/53237/diff/1-2/?file=1547685#file1547685line800> > > > > not yours but can you s/EXPECT/ASSERT/ so that the next line doesn't > > crash.
Fixed this and a bunch of instances of similar code in this test file. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53237/#review159828 ----------------------------------------------------------- On Dec. 19, 2016, 9:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53237/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 9:15 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5396 > https://issues.apache.org/jira/browse/MESOS-5396 > > > Repository: mesos > > > Description > ------- > > Check metrics, simplify/remove redundant code. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 6035171f7d66e728e4675634af3587f9c378e1e1 > src/tests/slave_recovery_tests.cpp 5b86c06803c59427c826b1b7039a5156a58e141b > > Diff: https://reviews.apache.org/r/53237/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
