-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54821/
-----------------------------------------------------------
(Updated Dec. 21, 2016, 6:52 p.m.)
Review request for mesos, Xiaojian Huang, haosdent huang, and Jie Yu.
Changes
-------
review comments.
Bugs: MESOS-6808
https://issues.apache.org/jira/browse/MESOS-6808
Repository: mesos
Description (updated)
-------
This patch creates a wrapper struct for all recognizable docker cli
options, and separate logic of creating these options to a different
common function.
This also enables us to overcome gmock's 10 argument limit.
No logic change happens in this refactoring patch.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp b2a547d9b1c5ac3922ed21bceb5c9b60fa9f6568
src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6
src/slave/containerizer/docker.cpp 7ef5928e3e971f7fcd59487a0242b3af689b0058
src/tests/containerizer/docker_containerizer_tests.cpp
6035171f7d66e728e4675634af3587f9c378e1e1
src/tests/containerizer/docker_tests.cpp
9667d434486c1832f180a297a39a3d5dae6a26bd
src/tests/mock_docker.hpp 829a760d54ad8c7b88256ae5df4c88c9fb18df71
src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502
Diff: https://reviews.apache.org/r/54821/diff/
Testing
-------
`make check` with ROOT and DOCKER filter.
Thanks,
Zhitao Li
