----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54946/ -----------------------------------------------------------
Review request for mesos and Michael Park. Repository: mesos Description ------- Classes should always use `virtual` inheritance when inheriting from `flags::FlagsBase`. In order to create properly composable flags classes, `virtual` inheritance should be used even for classes inheriting from classes inheriting from `FlagsBase` or any of their children. This change fixes the inheritance for a number of `FlagBase`-based classes. Diffs ----- src/examples/test_framework.cpp 753b4deb842d2da3a33ec78f5f4f55f406b3b00a src/examples/test_http_framework.cpp 579a0c5521a33edb85afebdcbaff886c4c16f2dc src/slave/main.cpp 8010f8e229e2d820649750c9db0456ecd1b854d3 Diff: https://reviews.apache.org/r/54946/diff/ Testing ------- `make check (Fedora 25, default build)` These instances were found the with the clang-tidy checker posted here, https://github.com/mesos/clang-tools-extra/pull/4. This commit fixes all instances found under an SSL build on OS X, and an ubuntu-16 build (both SSL, non-SSL). Thanks, Benjamin Bannier
