----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54953/#review159883 -----------------------------------------------------------
src/Makefile.am (line 88) <https://reviews.apache.org/r/54953/#comment230934> Should we remove this rather than defining it as empty here? I'm seeing the following warning during `./bootstrap`: ``` src/Makefile.am:111: warning: AM_LDFLAGS was already defined in condition TRUE, which includes condition ENABLE_HARDENING ... src/Makefile.am:88: ... 'AM_LDFLAGS' previously defined here ``` - Michael Park On Dec. 21, 2016, 2:50 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54953/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 2:50 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6830 > https://issues.apache.org/jira/browse/MESOS-6830 > > > Repository: mesos > > > Description > ------- > > The gold linker complains about using -pie without -fPIC which causes the > build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE > are enabled/disabled based on the setting for enabling/disabling hardening. > > > Diffs > ----- > > src/Makefile.am abcf7eed7 > > Diff: https://reviews.apache.org/r/54953/diff/ > > > Testing > ------- > > ../configure --disable-python --disable-java && make > ../configure --disable-python --disable-java --disable-hardening && make > > > Thanks, > > Aaron Wood > >
