----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54927/#review159948 -----------------------------------------------------------
Ship it! Note: typo in your commit summary `HAS_AUTHENTICATED` -> `HAS_AUTHENTICATION` :) - Joseph Wu On Dec. 20, 2016, 7:16 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54927/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 7:16 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Bugs: MESOS-6803 > https://issues.apache.org/jira/browse/MESOS-6803 > > > Repository: mesos > > > Description > ------- > > This is a follow-on to 54803. > > Currently, when `HAS_AUTHENTICATION` is undefined, the Agent will > use `delay` to schedule a random time in the future to register with the > Master, to avoid the thundering herd problem after a Master failover. > The authentication codepath, in contrast, schedules the registration > immediately. > > In tests where we have `Clock::pause`'d when we are supposed to be > registering the slave, the authention codepath will succeeed, while > no-authentication codepath will hang forever. > > A much more detailed analysis of this situation exists in MESOS-6803. > > This commit will resolve this issue for a few existing test files by > changing the tests to not use `Clock::pause` when we are waiting for > Agent registration. > > > Diffs > ----- > > src/tests/partition_tests.cpp e1e2025bd0f078836323cbd8c6d7836815c4c38d > > Diff: https://reviews.apache.org/r/54927/diff/ > > > Testing > ------- > > `make check` and each test was run 1000 times to avoid flakey tests. > > > Thanks, > > Alex Clemmer > >
