----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55025/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu. Repository: mesos Description ------- Currently in the test harness, we pass the flags `-DSOURCE_DIR` and `-DBUILD_DIR` to the compiler. These are used to do things like determine where the containerizer is to launch it for tests. On Windows, these paths should be Windows-style, with '\' characters separating path components. Unfortunately, CMake does not escape these slashes in path strings, so when we pass them as preprocessor flags, a string like `C:\src` will look to the standard Windows API like a string with an escaped '\s' character. On the other hand, Windows APIs are happy to take Unix-style paths as arguments. So, to unblock making the agent tests work, we simply use Unix paths here. Diffs ----- src/tests/cmake/MesosTestsConfigure.cmake ca042bd3f7ebc339f1c342b1854a66e33ee9f20c Diff: https://reviews.apache.org/r/55025/diff/ Testing ------- Thanks, Alex Clemmer
