-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54999/
-----------------------------------------------------------
(Updated Dec. 28, 2016, 9:23 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Changes
-------
Fix typo, tweak comment.
Bugs: MESOS-6837
https://issues.apache.org/jira/browse/MESOS-6837
Repository: mesos
Description
-------
`FaultToleranceTest.FrameworkReregister` and
`MasterTest.FailoverAgentReregisterFirst` both examined a timestamp
value returned by an HTTP endpoint. Such values are the result of
several conversions (`double` to `string` to `JSON::Value`); this might
result in the returned value being an integer one larger/smaller than we
expect. Hence, make the comparison within an epsilon of 1.
A similar issue in `SlaveTest.StateEndpoint` was fixed in
595c929f2816b713b4c36ce1bd23a7767afe8135.
Diffs (updated)
-----
src/tests/fault_tolerance_tests.cpp 24747fab20f5b107b9c23a271b753e83f05bbee3
src/tests/master_tests.cpp 2d0cd8244ded44e76f0eee3d87327ff526db5208
src/tests/slave_tests.cpp 67a6aed8c66a21c94c106b52dff75cbdc41fcf69
Diff: https://reviews.apache.org/r/54999/diff/
Testing
-------
`make check`
Note that I wasn't able to repro the test failure on my laptop, but it was
observed on CI.
Thanks,
Neil Conway
