> On 十二月 28, 2016, 9:24 a.m., Guangya Liu wrote: > > src/common/protobuf_utils.hpp, lines 238-243 > > <https://reviews.apache.org/r/55021/diff/2/?file=1592796#file1592796line238> > > > > I'd like we keep a comment for each of the capability here and also > > keep the variable same as before. > > ``` > > // Whether the framework desires revocable resources. > > bool revocable = false; > > > > // Whether the framework can receive TASK_KILLING TaskState > > // when a task is being killed. > > bool taskKillingAware = false; > > > > // Whether the framework is aware of GPU resources. See > > // the documentation for the GPU_RESOURCES Capability. > > bool gpuAware = false; > > > > // Whether the framework desires shared resources. > > bool shared = false; > > > > // Whether the framework is prepared to handle the following > > // TaskStates: TASK_UNREACHABLE, TASK_DROPPED, TASK_GONE, > > // TASK_GONE_BY_OPERATOR, and TASK_UNKNOWN, and whether the > > // framework will assume responsibility for managing > > // partitioned tasks that reregister with the master. > > bool partitionAware = false; > > > > // Whether the framework support `multi-tenancy`. > > bool multiRole = false; > > ``` > > Jay Guo wrote: > previous naming seems more reasonable from literal perspective but as the > # of caps grows, it looks more straightforward to me to keep the consistency. > what do you think?
I have no comments for this but it is better leave some comments for each capability as before. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160217 ----------------------------------------------------------- On 十二月 29, 2016, 1:37 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55021/ > ----------------------------------------------------------- > > (Updated 十二月 29, 2016, 1:37 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > Master, agent and allocator structs could use this stuct to easily > deal with Framework Capabilities. > > > Diffs > ----- > > src/common/protobuf_utils.hpp f225bb0f5196f7f4b12be25828361a38e1d42e60 > src/tests/protobuf_utils_tests.cpp 4ce952a7d3901a4362aa69f199b135b53d14a723 > > Diff: https://reviews.apache.org/r/55021/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
