> On Dec. 23, 2016, 10:40 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 66 > > <https://reviews.apache.org/r/54952/diff/2/?file=1591277#file1591277line66> > > > > How about pulling `delete[] buffer` before the comment because it is > > common to both found/not found cases (similar to what you do for the `else` > > case below)? > > > > Ideally we should use something like `BOOST_SCOPE_EXIT` or > > `std::vector` in combination with `vector::reserve()`, but this is probably > > should be done consistenly across stout.
Now when you extended the patch to `os::user` I see that we use `pwd.pw_name` there and hence cannot deallocate the buffer at the beginning of the if-clause. It probably makes sense to leave things as is for local consistency. Dropping the issue. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54952/#review160065 ----------------------------------------------------------- On Dec. 28, 2016, 9:50 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54952/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2016, 9:50 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-6826 > https://issues.apache.org/jira/browse/MESOS-6826 > > > Repository: mesos > > > Description > ------- > > According to POSIX, `getpwnam_r` returns 0 (and sets `result` to the > null pointer) when the specified user name is not found. However, > certain versions of Linux (e.g., RHEL7, recent Arch Linux) return > non-zero and set `errno` (to one of several different values) when > `getpwnam_r` is passed an invalid user name. > > In stout, we want to treat the "invalid user name" and "user name not > found" cases the same. Both the POSIX spec and Linux manpages call out > certain errno values as definitely indicating errors (e.g., EIO, > EMFILE). Hence, we check `errno` and return an error to the caller if > `errno` appears in that list. We treat `errno` values not in that list > as equivalent to "user not found". > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/su.hpp > f3f45ebf006f0f8e7e70b0f4c4ed76465530c58e > 3rdparty/stout/tests/os_tests.cpp 8d2005b1f109b4025aa8368600763db9c829d0c5 > > Diff: https://reviews.apache.org/r/54952/diff/ > > > Testing > ------- > > `make check` on Arch Linux. `OsTest.User` fails without this patch but > succeeds with this patch. > > > Thanks, > > Neil Conway > >
