> On Dec. 27, 2016, 5:14 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt, line 67 > > <https://reviews.apache.org/r/55005/diff/1/?file=1591507#file1591507line67> > > > > s/process-tests/libprocess-tests/ ? > > Alex Clemmer wrote: > I would say this is not necessary. On `libx` is a POSIX convention. For > example, `libprocess.a` on POSIX would usually be `process.lib` on Windows.
This name is fine. The goal here is to match the autotools name, which creates a test binary called `libprocess-tests`. Library files will still get the appropriate name on Posix/Windows, as those names are mostly autogenerated by the build system. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55005/#review160156 ----------------------------------------------------------- On Dec. 22, 2016, 6:09 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55005/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 6:09 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > See https://reviews.apache.org/r/55006/. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a > 3rdparty/libprocess/src/tests/CMakeLists.txt > 4b80c397381ca2c869cd6eb7507bb9df94ce3623 > > Diff: https://reviews.apache.org/r/55005/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
