----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52738/#review160819 -----------------------------------------------------------
Patch looks great! Reviews applied: [52680, 52727, 52666, 52728, 52738] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Jan. 7, 2017, 11:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52738/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2017, 11:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > After image pull finished, use `inspectImage` to get > the returned image value. > > > Diffs > ----- > > src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 > > Diff: https://reviews.apache.org/r/52738/diff/ > > > Testing > ------- > > make > make check > > Also test with a real cases. > > 1) Remove busybox:latest > 2) Launch a task using busybox:latest , succeed. > 3) Check agent log, it is using `inspectImage` to inspect the pulled image as > `I0107 19:21:33.227638 19845 docker.cpp:1219] Running docker -H > unix:///var/run/docker.sock inspect busybox:latest`. > ``` > I0107 19:20:46.989816 19851 docker.cpp:1126] Starting container > 'fa2bff2b-2c48-4afd-842d-cc742bc44afd' for task 'test_mesos' (and executor > 'test_mesos') of framework 3ba2d123-524c-4d44-b6cf-5a440c3286be-0000 > I0107 19:20:46.991299 19846 fetcher.cpp:349] Starting to fetch URIs for > container: fa2bff2b-2c48-4afd-842d-cc742bc44afd, directory: > /tmp/mesos/slave/slaves/3ba2d123-524c-4d44-b6cf-5a440c3286be-S0/frameworks/3ba2d123-524c-4d44-b6cf-5a440c3286be-0000/executors/test_mesos/runs/fa2bff2b-2c48-4afd-842d-cc742bc44afd > I0107 19:20:46.993584 19846 docker.cpp:1519] Running docker -H > unix:///var/run/docker.sock inspect busybox:latest > I0107 19:20:47.033046 19850 docker.cpp:1593] Running docker -H > unix:///var/run/docker.sock pull busybox:latest > I0107 19:20:55.868794 19848 slave.cpp:5589] Querying resource estimator for > oversubscribable resources > I0107 19:20:55.869504 19848 slave.cpp:5603] Received oversubscribable > resources {} from the resource estimator > I0107 19:20:56.662844 19846 slave.cpp:4275] Received ping from > slave-observer(1)@192.168.56.12:5050 > I0107 19:21:10.871165 19850 slave.cpp:5589] Querying resource estimator for > oversubscribable resources > I0107 19:21:10.871886 19850 slave.cpp:5603] Received oversubscribable > resources {} from the resource estimator > I0107 19:21:11.664295 19849 slave.cpp:4275] Received ping from > slave-observer(1)@192.168.56.12:5050 > I0107 19:21:25.873539 19848 slave.cpp:5589] Querying resource estimator for > oversubscribable resources > I0107 19:21:25.873878 19848 slave.cpp:5603] Received oversubscribable > resources {} from the resource estimator > I0107 19:21:26.665603 19845 slave.cpp:4275] Received ping from > slave-observer(1)@192.168.56.12:5050 > I0107 19:21:33.227638 19845 docker.cpp:1219] Running docker -H > unix:///var/run/docker.sock inspect busybox:latest > I0107 19:21:33.335652 19852 docker.cpp:445] Docker pull busybox:latest > completed > I0107 19:21:33.337988 19852 docker.cpp:1480] Launching > 'mesos-docker-executor' with flags > '--container="mesos-3ba2d123-524c-4d44-b6cf-5a440c3286be-S0.fa2bff2b-2c48-4afd-842d-cc742bc44afd" > --docker="docker" --docker_socket="/var/run/docker.sock" --help="false" > --initialize_driver_logging="true" > --launcher_dir="/root/src/mesos/m1/mesos/build/src" --logbufsecs="0" > --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" > --quiet="false" > --sandbox_directory="/tmp/mesos/slave/slaves/3ba2d123-524c-4d44-b6cf-5a440c3286be-S0/frameworks/3ba2d123-524c-4d44-b6cf-5a440c3286be-0000/executors/test_mesos/runs/fa2bff2b-2c48-4afd-842d-cc742bc44afd" > --stop_timeout="0ns"' > I0107 19:21:33.402930 19850 slave.cpp:3320] Got registration for executor > 'test_mesos' of framework 3ba2d123-524c-4d44-b6cf-5a440c3286be-0000 from > executor(1)@192.168.56.12:46096 > I0107 19:21:33.404538 19850 docker.cpp:1574] Ignoring updating container > fa2bff2b-2c48-4afd-842d-cc742bc44afd because resources passed to update are > identical to existing resources > I0107 19:21:33.405146 19850 slave.cpp:2265] Sending queued task 'test_mesos' > to executor 'test_mesos' of framework > 3ba2d123-524c-4d44-b6cf-5a440c3286be-0000 at executor(1)@192.168.56.12:46096 > I0107 19:21:34.016574 19847 slave.cpp:3752] Handling status update > TASK_RUNNING (UUID: c606b507-14e8-41e8-a1d4-b5f34db4fda1) for task test_mesos > of framework 3ba2d123-524c-4d44-b6cf-5a440c3286be-0000 from > executor(1)@192.168.56.12:46096 > I0107 19:21:34.018025 19846 status_update_manager.cpp:323] Received status > update TASK_RUNNING (UUID: c606b507-14e8-41e8-a1d4-b5f34db4fda1) for task > test_mesos of framework 3ba2d123-524c-4d44-b6cf-5a440c3286be-0000 > ``` > > > Thanks, > > Guangya Liu > >
