> On Jan. 9, 2017, 7:47 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 672-679 > > <https://reviews.apache.org/r/55157/diff/1-2/?file=1596482#file1596482line672> > > > > shouldn't these be re-ordered? i'm assuming we don't need to call > > `__shutdown()` if a shutdown is already in progress?
As per our offline discussion, we can't reorder them as `shutdown()` doesn't invoke `__shutdown` implicitly to commit suicide. We wait for all our wait connections to return and commit suicide thereafter in `waited()`. This allows us to keep all the restart/kill policy logic in one place in `waited()`. I would add a comment in `shutdown()` in a separate review for posterity. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55157/#review160946 ----------------------------------------------------------- On Jan. 9, 2017, 7:37 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55157/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 7:37 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6848 > https://issues.apache.org/jira/browse/MESOS-6848 > > > Repository: mesos > > > Description > ------- > > This bug is only observed when the task group contains a single task. > The default executor was not committing suicide when this single task > used to exit with a non-zero status code as per the default restart > policy. > > > Diffs > ----- > > src/launcher/default_executor.cpp fd9963996c82461b60888397989e309d51b60aaa > src/tests/default_executor_tests.cpp > 340e8c8b36a6a3cc6e5bae021e19dfa7a54852c3 > > Diff: https://reviews.apache.org/r/55157/diff/ > > > Testing > ------- > > make check + added a test > > > Thanks, > > Anand Mazumdar > >
