----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55219/#review160983 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Jan. 5, 2017, 11:06 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55219/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 11:06 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Avoid redundant initialization to empty string, use `char` overloads > instead for single-character string literals. > > Spotted with clang-tidy. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp > 61d17a9d50f2115ca2228ec4b05cdbb874c595c5 > 3rdparty/stout/include/stout/gzip.hpp > 97891860dbdd7095d5498695ad0e97ad02e35d73 > 3rdparty/stout/include/stout/os/mkdir.hpp > fe86864c8b480993c8f052f39b2fd3ece23798da > 3rdparty/stout/include/stout/path.hpp > d1092f6cccfb9dc53154ce9ce09414d57526a76d > 3rdparty/stout/tests/ip_tests.cpp 84eb75ee7e1e9ec04527ade3bb8aeba93301ab19 > > Diff: https://reviews.apache.org/r/55219/diff/ > > > Testing > ------- > > `make check` on OSX and Linux, plus internal CI. > > > Thanks, > > Neil Conway > >