----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55220/#review160985 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Jan. 5, 2017, 12:04 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55220/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 12:04 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Avoid redundant initialization to empty string, use `char` overloads > instead for single-character string literals. > > Spotted with clang-tidy. > > > Diffs > ----- > > src/common/resources.cpp 7dbeefc8fc159f28dc1542ad6a761213c65ff226 > src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 > src/slave/containerizer/fetcher.cpp > 94cfa0e33adc622d77a75e256fb52fc75d3db18a > src/state/zookeeper.cpp 9941f6b3f9da264d3b75d74edfc60afc740bc74e > src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93 > src/v1/resources.cpp 859f7388035b855bf0cb60d5cbe746e6871bf833 > src/zookeeper/zookeeper.cpp e105377ed0ceba22b03c27ab1209e7a96c284066 > > Diff: https://reviews.apache.org/r/55220/diff/ > > > Testing > ------- > > `make check` on OSX and Linux, plus internal CI. > > > Thanks, > > Neil Conway > >
