----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55177/#review161107 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Jan. 6, 2017, 11:37 a.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55177/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 11:37 a.m.) > > > Review request for mesos, Benjamin Mahler and Timothy Chen. > > > Bugs: MESOS-6871 > https://issues.apache.org/jira/browse/MESOS-6871 > > > Repository: mesos > > > Description > ------- > > This method could mistake the host part for the scheme because of > unsuitable use of find_first_of(). > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023 > 3rdparty/libprocess/src/tests/http_tests.cpp > d168ad15da4706fb9c3aa11a125b7dfb5987570d > > Diff: https://reviews.apache.org/r/55177/diff/ > > > Testing > ------- > > Added a test case demonstrating the problem. Ran `make check`. > > > Thanks, > > Ilya Pronin > >
