----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54407/#review161159 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/54407/#comment232395> I think we (I?) originially didn't call `deactivate` here because that causes rescind messages to be sent to the framework, which don't make sense here. Maybe `decativate` can take a `bool rescind`? - Vinod Kone On Jan. 10, 2017, 10:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54407/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 10:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6719 > https://issues.apache.org/jira/browse/MESOS-6719 > > > Repository: mesos > > > Description > ------- > > Refactored Master::removeFramework to use Master::deactivate. > > > Diffs > ----- > > src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 > > Diff: https://reviews.apache.org/r/54407/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
