----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55400/#review161169 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp (line 1598) <https://reviews.apache.org/r/55400/#comment232405> Technically, we expect the return type to be `Future<http::Response>`, to match the return type of the function. - Joseph Wu On Jan. 10, 2017, 5:28 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55400/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 5:28 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > `clang-3.5` performs incorrect type deduction for lambda return types. > Namely, > > ```cpp > struct S {}; > auto l = [](const S& s) { return s; } > ``` > > The deduced return type of lambda `l` is `const S` as opposed to `S`. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > c444568dd478902afd79fe3c8960364fd68fabb5 > > Diff: https://reviews.apache.org/r/55400/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
