----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161199 -----------------------------------------------------------
If we implement the recursive chown this way, I feel that we need some unit tests, I don't think higher-level tests have enough coverage for this method. If we replace it with `os::spawn()` it's more trivial that I think we can skip the test for now. What do you prefer? - Jiang Yan Xu On Jan. 5, 2017, 5:18 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55242/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 5:18 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6862 > https://issues.apache.org/jira/browse/MESOS-6862 > > > Repository: mesos > > > Description > ------- > > Stop using os::system to chown a directory hierarchy. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/chown.hpp > c82e2e574019c5ee5f17ea105a6d225006388a45 > > Diff: https://reviews.apache.org/r/55242/diff/ > > > Testing > ------- > > `sudo make check` (Fedora 25) > > > Thanks, > > James Peach > >
