----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55241/#review161257 -----------------------------------------------------------
src/linux/perf.cpp (line 327) <https://reviews.apache.org/r/55241/#comment232493> It adds `true` to the commandline like the original code does. The `perf` commands generally need a subcommand to execute. src/linux/perf.cpp (lines 329 - 341) <https://reviews.apache.org/r/55241/#comment232501> I expect that the original author didn't use the `Perf` because they didn't want to capture the output. But I don't see why your suggestion wouldn't work. If it weren't for the redirection I would have just replaced this with `spawn`. src/linux/perf.cpp (line 333) <https://reviews.apache.org/r/55241/#comment232494> The original code only redirected `stderr` so I've preserved that here. - James Peach On Jan. 6, 2017, 1:17 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55241/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 1:17 a.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu. > > > Bugs: MESOS-6862 > https://issues.apache.org/jira/browse/MESOS-6862 > > > Repository: mesos > > > Description > ------- > > Stop using os::system to validate perf event names. > > > Diffs > ----- > > src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f > > Diff: https://reviews.apache.org/r/55241/diff/ > > > Testing > ------- > > `sudo make check` (Fedora 25) > > > Thanks, > > James Peach > >
