----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/#review161362 -----------------------------------------------------------
Ship it! It would be great to add sth in `Testing Done` section to verify that the test cases you updated still works well. - Guangya Liu On 一月 12, 2017, 8:56 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55445/ > ----------------------------------------------------------- > > (Updated 一月 12, 2017, 8:56 a.m.) > > > Review request for mesos, Benjamin Mahler and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > In currently implementation, update of role during framework failover > is ignored. This behavior should be reflected in test. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 05937a917a2c175aa53b52488febb7cfd8400a13 > > Diff: https://reviews.apache.org/r/55445/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
