> On Jan. 13, 2017, 10:50 a.m., Anindya Sinha wrote: > > src/common/validation.cpp, line 36 > > <https://reviews.apache.org/r/55446/diff/1/?file=1603766#file1603766line36> > > > > Should we consider disallowing spaces as well? `iscntrl` includes tabs > > but do we want spaces to be included in the path?
IMO we should but we currently don't. This patch doesn't propose new rules. I was going to create a JIRA for some new rules but JIRA is down. :( - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55446/#review161560 ----------------------------------------------------------- On Jan. 12, 2017, 1:46 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55446/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 1:46 a.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu. > > > Bugs: MESOS-6866 > https://issues.apache.org/jira/browse/MESOS-6866 > > > Repository: mesos > > > Description > ------- > > - The common validation logic is shared by the master and the agent. > > > Diffs > ----- > > src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c > src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c > src/common/validation.hpp PRE-CREATION > src/common/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/55446/diff/ > > > Testing > ------- > > make check > Tested with /r/55449/ > > > Thanks, > > Jiang Yan Xu > >
