-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55343/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 7:19 p.m.)
Review request for mesos, Benjamin Hindman and Joseph Wu.
Bugs: MESOS-6789
https://issues.apache.org/jira/browse/MESOS-6789
Repository: mesos
Description
-------
Recently, a change was made to the signature of
`Socket::shutdown`, but the corresponding override in
`LibeventSSLSocketImpl` was not updated, so that the
implementation-specific method is no longer being
executed. Further, the SSL socket's `shutdown` code
did not actually shutdown the socket; rather, the
shutdown was performed in the destructor.
This patch updates the function's signature to match
that of the base class's method, adds the `override`
specifier to the implemention's method declaration,
and updates the function to properly shutdown the
SSL socket.
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp
87966155aa21328db51796b2ae0a883054c00457
3rdparty/libprocess/src/libevent_ssl_socket.hpp
65da091155107d77bdf7b003609ab3770f80083a
3rdparty/libprocess/src/libevent_ssl_socket.cpp
b0319b2d3694f600190615ba6d29b95b1d8f2405
Diff: https://reviews.apache.org/r/55343/diff/
Testing
-------
`3rdparty/libprocess/libprocess-tests
--gtest_filter="Encryption/NetSocketTest.EOFBeforeRecv/0:Encryption/NetSocketTest.EOFAfterRecv/0"
--gtest_repeat=-1 --gtest_break_on_failure`
NOTE: currently the above command exposes a file descriptor leak related to the
SSL socket.
Thanks,
Greg Mann
