----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55447/#review161582 -----------------------------------------------------------
Ship it! Ship It! - James Peach On Jan. 12, 2017, 9:48 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55447/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 9:48 a.m.) > > > Review request for mesos, Benjamin Mahler and James Peach. > > > Bugs: MESOS-6866 > https://issues.apache.org/jira/browse/MESOS-6866 > > > Repository: mesos > > > Description > ------- > > The context for adding these is MESOS-6866. Addmittedly these checks only > protect against a (small) subset of potential attacks by clients spoofing as > the master and we need MESOS-6903 to truely fix the issue. However instead of > ad-hoc bandaids, these could be considered good programming practices: CHECK > preconditions before performing (potentially dangerous) actions so I think > this is still reasonable. > > > Diffs > ----- > > src/slave/paths.cpp 8792cee43d94e7b0bbd7b80aebbe501236244621 > > Diff: https://reviews.apache.org/r/55447/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
