----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55066/#review161606 -----------------------------------------------------------
Fix it, then Ship it! src/master/http.cpp (line 236) <https://reviews.apache.org/r/55066/#comment232867> Can you fix this separately? - Benjamin Mahler On Jan. 5, 2017, 12:19 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55066/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 12:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > When Framework struct is constructed, Capabilities is initialized > with capabilities in FrameworkInfo. Some of `frameworkHasCapability` > are then retired in favor of checking boolean value in Capabilities. > > > Diffs > ----- > > src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667 > src/master/master.hpp 57fc6e6f2995078df80f0aa52707727db802ede0 > src/master/master.cpp 11c34a048586d30c6ac67be8638ed8fa81cc3f1f > src/slave/http.cpp b6e2d4f9190358d113b39140d116b8659ddbb49b > src/slave/slave.hpp acb4f6581fcf22f9a748f6ccea48665542e76bc3 > src/slave/slave.cpp f8f2ccfadb9a00be17c0b552586aa5875b7cbb19 > > Diff: https://reviews.apache.org/r/55066/diff/ > > > Testing > ------- > > make check on Ubuntu 14.04 > > > Thanks, > > Jay Guo > >
