> On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 19 > > <https://reviews.apache.org/r/55489/diff/2/?file=1604529#file1604529line19> > > > > Should we also set `pipefail`?
I didn't know about that. Sounds great. > On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 34 > > <https://reviews.apache.org/r/55489/diff/2/?file=1604529#file1604529line34> > > > > It seems something like this would still be useful for the cmake build > > so callers could pass extra configuration flags (e.g., of the form > > `-DENABLE_DEBUG=ON`). I'll add this back. > On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote: > > support/mesos-tidy/entrypoint.sh, line 27 > > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line27> > > > > Left over debug tooling? I use this a bunch of times below. > On Jan. 13, 2017, 4 a.m., Benjamin Bannier wrote: > > support/mesos-tidy/entrypoint.sh, line 33 > > <https://reviews.apache.org/r/55489/diff/2/?file=1604531#file1604531line33> > > > > I don't think the folks interested in cmake would ever see this comment > > here. We should create tickets and link them here. Created MESOS-6924 and MESOS-6925 - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55489/#review161500 ----------------------------------------------------------- On Jan. 13, 2017, 1:59 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55489/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 1:59 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Used CMake to generate the compilation database instead. > > > Diffs > ----- > > support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7 > support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464 > support/mesos-tidy/entrypoint.sh 72872375f3e5ad19bc75949f9e3db14d6068f9b6 > > Diff: https://reviews.apache.org/r/55489/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
