----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review161660 -----------------------------------------------------------
Fix it, then Ship it! This is great. Could you make sure to follow up with setting `mesos/mesos-tidy` up for automated builds? Before building the image in the dockerhub time constraints was hard, but I am optimistic this would work now with the changes from https://reviews.apache.org/r/55488/. support/mesos-tidy.sh (line 39) <https://reviews.apache.org/r/55490/#comment232930> Removing the image sure made sense for an always regenerated image, but does it also for a relatively static image? I as a developer would prefer to not always have to repull the image, but maybe e.g., a CI has different constraints. Let's keep the `docker pull` to ensure a recent enough image, but let's remove the `docker rmi`. - Benjamin Bannier On Jan. 14, 2017, 9:02 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55490/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2017, 9:02 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Used the `mesos/mesos-tidy` image from DockerHub. > > > Diffs > ----- > > support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7 > > Diff: https://reviews.apache.org/r/55490/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
